FIX: verify if role exists in getUserList API

mooctest-site-server/src/main/java/cn/iselab/mooctest/site/web/ctrl/UserController.java

@@ -181,7 +181,8 @@ public class UserController {
         Integer activePage = Integer.parseInt(activePageStr);
         Integer rowsOnPage = Integer.parseInt(rowsOnPageStr);
         Sort sortById = new Sort(Sort.Direction.DESC, "id");
-        return userLogic.getUserListByRoleId(roleId, new PageRequest(activePage - 1, rowsOnPage, sortById));
+        Page<UserVO> userListByRoleId = userLogic.getUserListByRoleId(roleId, new PageRequest(activePage - 1, rowsOnPage, sortById));
+        return userListByRoleId;
     }
 
 

mooctest-site-server/src/main/java/cn/iselab/mooctest/site/web/logic/impl/UserLogicImpl.java

@@ -389,6 +389,9 @@ public class UserLogicImpl extends BaseLogic implements UserLogic {
 
     @Override
     public Page<UserVO> getUserListByRoleId(Long roleId, Pageable pageable) {
+        if (roleService.findById(roleId) == null){
+            throw new HttpBadRequestException("this role does not exist");
+        }
         Page<User> userList = userService.findByRoleId(roleId, pageable);
         return userVOWrapper.wrap(userList);
     }