|
@@ -4,6 +4,7 @@ import com.mooctest.dao.BugDataDao;
|
|
|
import com.mooctest.dao.MasterReportDao;
|
|
|
import com.mooctest.model.BugData;
|
|
|
import com.mooctest.model.MasterReport;
|
|
|
+import com.mooctest.util.ReviewStatus;
|
|
|
import org.springframework.beans.factory.annotation.Autowired;
|
|
|
import org.springframework.stereotype.Service;
|
|
|
|
|
@@ -80,17 +81,15 @@ public class BugReviewService {
|
|
|
public boolean masterReview2(String masterId ){
|
|
|
List<MasterReport> mrs = masterReportDao.findByMasterId(masterId);
|
|
|
List<String> bugIds = mrs.stream().map(MasterReport::getBugId).collect(Collectors.toList());
|
|
|
- updateBugReviewed(bugIds);
|
|
|
- return true;
|
|
|
+ return updateBugReviewedMulti(bugIds);
|
|
|
}
|
|
|
|
|
|
public boolean treeReview2(String treeId){
|
|
|
// 仅仅是将这一份报告的状态设置为已经review, 如果这个报告还有tree报告或者master报告还没review 就提示无法review。
|
|
|
//如果是树状的root 和master报告就要看是不是下面的报告已经都审核了
|
|
|
- List<String> childs = historyService.getSingleRootReports(treeId);
|
|
|
- childs.add(treeId);
|
|
|
- updateBugReviewed(childs);
|
|
|
- return true;
|
|
|
+ List<String> bugs = historyService.getSingleRootReports(treeId);
|
|
|
+ bugs.add(treeId);
|
|
|
+ return updateBugReviewedMulti(bugs);
|
|
|
}
|
|
|
|
|
|
/**
|
|
@@ -99,8 +98,9 @@ public class BugReviewService {
|
|
|
* @return 是否审核成功
|
|
|
*/
|
|
|
public boolean singleReportReview2 (String reportId){ //
|
|
|
- updateSingleBugReview(reportId);
|
|
|
- return true;
|
|
|
+// updateSingleBugReview(reportId);
|
|
|
+// return true;
|
|
|
+ return updateBugReviewedSingle(reportId);
|
|
|
}
|
|
|
|
|
|
|
|
@@ -124,8 +124,8 @@ public class BugReviewService {
|
|
|
child = child.stream().distinct().collect(Collectors.toList());
|
|
|
child.remove(reportId);
|
|
|
if(isAllRemove(child)){
|
|
|
- updateSingleBugReview(reportId);
|
|
|
- return true;
|
|
|
+// updateSingleBugReview(reportId);
|
|
|
+ return updateBugReviewedSingle(reportId);
|
|
|
}else{
|
|
|
return false;
|
|
|
}
|
|
@@ -150,12 +150,33 @@ public class BugReviewService {
|
|
|
updateBugReviewed(bugIds);
|
|
|
}
|
|
|
|
|
|
- private void updateSingleBugReview ( String id ){
|
|
|
- BugData single = bugDataDao.findByBugId(id);
|
|
|
- single.setStatus(1);
|
|
|
- bugDataDao.save(single);
|
|
|
+// private void updateSingleBugReview ( String id ){
|
|
|
+// BugData single = bugDataDao.findByBugId(id);
|
|
|
+// single.setStatus(1);
|
|
|
+// bugDataDao.save(single);
|
|
|
+// }
|
|
|
+
|
|
|
+ private boolean updateBugReviewedSingle(String bugId){
|
|
|
+ BugData single = bugDataDao.findByBugId(bugId);
|
|
|
+ single.setStatus(ReviewStatus.REVIEWED.getReviewStatus());
|
|
|
+ single.setReviewerId(1l);
|
|
|
+ return null != bugDataDao.save(single);
|
|
|
+// single.set
|
|
|
+ }
|
|
|
+
|
|
|
+ /**
|
|
|
+ * 使用 BugData 记录报告的更新状态,不再使用原来的MasterReport
|
|
|
+ */
|
|
|
+ private boolean updateBugReviewedMulti(List<String> bugIds){
|
|
|
+ List<BugData> bugList = bugDataService.getBugDataByIds(bugIds);
|
|
|
+ for(BugData bug : bugList){
|
|
|
+ bug.setStatus(ReviewStatus.REVIEWED.getReviewStatus());
|
|
|
+ bug.setReviewerId(1l);
|
|
|
+ }
|
|
|
+ return bugDataService.saveMultiple(bugList);
|
|
|
}
|
|
|
|
|
|
+
|
|
|
// 废弃方法
|
|
|
private void updateBugReviewed(List<String> bugIds) {
|
|
|
List<MasterReport> mrs = masterReportDao.findByBugIdIn(bugIds);
|