Переглянути джерело

添加对上传reviewPaper的测试

MengyangDuan 5 роки тому
батько
коміт
8a9e528d9e

+ 1 - 13
src/main/java/edu/nju/entities/ReviewJob.java

@@ -20,8 +20,6 @@ public class ReviewJob implements java.io.Serializable{
 
     private String paper_id;
 
-    private String type;
-
     private String create_time;
 
     private String start_time;
@@ -37,13 +35,12 @@ public class ReviewJob implements java.io.Serializable{
     private int max_worker;
 
     @PersistenceConstructor
-    public ReviewJob(String exam_id,String case_id, String name, String description, String create_time, String paper_id,String type, String start_time, String end_time, String group,Boolean isCrossValidation,Integer validationNum,Integer max_worker) {
+    public ReviewJob(String exam_id,String case_id, String name, String description, String create_time, String paper_id, String start_time, String end_time, String group,Boolean isCrossValidation,Integer validationNum,Integer max_worker) {
         this.exam_id=exam_id;
         this.case_id=case_id;
         this.description = description;
         this.name = name;
         this.paper_id = paper_id;
-        this.type=type;
         this.create_time = create_time;
         this.start_time = start_time;
         this.end_time = end_time;
@@ -71,7 +68,6 @@ public class ReviewJob implements java.io.Serializable{
         this.description = "";
         this.name = "";
         this.paper_id = paper_id;
-        this.type="";
         this.create_time = create_time;
         this.start_time = "";
         this.end_time = "";
@@ -175,14 +171,6 @@ public class ReviewJob implements java.io.Serializable{
         this.case_id = case_id;
     }
 
-    public String getType() {
-        return type;
-    }
-
-    public void setType(String type) {
-        this.type = type;
-    }
-
     public int getMax_worker() {
         return max_worker;
     }

+ 1 - 1
src/main/java/edu/nju/service/ReviewJobService.java

@@ -52,7 +52,7 @@ public class ReviewJobService {
             return jsonObject;
         }
         if(jobId.equals("")) {
-            ReviewJob newReviewJob = new ReviewJob(examId, caseId, name, description, Long.toString(System.currentTimeMillis()), paperId,reviewPaper.getId(), startTime, endTime, "", isCrossValidation, validationNum,maxWorker);
+            ReviewJob newReviewJob = new ReviewJob(examId, caseId, name, description, Long.toString(System.currentTimeMillis()), paperId, startTime, endTime, "", isCrossValidation, validationNum,maxWorker);
             jobId = jobDao.save(newReviewJob);
         }
         if(workerDistribution.equals("")||workerDistribution.equals("[]")){

+ 74 - 0
src/test/java/edu/nju/service/ReviewPaperServiceTest.java

@@ -0,0 +1,74 @@
+package edu.nju.service;
+
+import edu.nju.dao.ReviewItemDao;
+import edu.nju.dao.ReviewPaperDao;
+import edu.nju.entities.ReviewItem;
+import edu.nju.entities.ReviewPaper;
+import org.json.JSONException;
+import org.json.JSONObject;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.mockito.Matchers.any;
+
+
+public class ReviewPaperServiceTest {
+
+    @InjectMocks
+    private ReviewPaperService reviewPaperService;
+    @Mock
+    private ReviewPaperDao reviewPaperDao;;
+    @Mock
+    private ReviewItemDao reviewItemDao;
+
+
+    @Before
+    public void setUp() throws Exception {
+        MockitoAnnotations.initMocks(this);
+    }
+
+    @Test
+    public void should_uploadPaper_when_invoked() {
+        //arrange
+        String paperJson="";
+        List<Long> groupIds = new ArrayList<>();
+        groupIds.add(123L);
+        //action
+        JSONObject jsonObject=reviewPaperService.uploadPaper(paperJson);
+        //assert
+        try {
+            Assert.assertEquals("success", jsonObject.getString("status"));
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        Mockito.verify(reviewPaperDao).save(any(ReviewPaper.class));
+        Mockito.verify(reviewItemDao.saveItem(any(ReviewItem.class)));
+    }
+
+    @Test
+    public void should_updatePaper_when_invoked() {
+        //action
+        String paperJson="";
+        String paperId="";
+        //action
+        JSONObject jsonObject=reviewPaperService.updatePaper(paperId,paperJson);
+        //assert
+        try {
+            Assert.assertEquals("success", jsonObject.getString("status"));
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        Mockito.verify(reviewPaperDao).save(any(ReviewPaper.class));
+        Mockito.verify(reviewItemDao.saveItem(any(ReviewItem.class)));
+    }
+
+}