123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893 |
- import json
- import os
- from types import SimpleNamespace
- import mock
- import pytest
- from mock import patch, MagicMock
- with patch.dict(os.environ, {"QueryQueue": "test"}):
- from backend.lambdas.tasks.generate_queries import (
- cast_to_type,
- column_mapper,
- generate_athena_queries,
- get_data_mappers,
- get_deletion_queue,
- get_inner_children,
- get_nested_children,
- get_partitions,
- get_table,
- handler,
- write_partitions,
- )
- pytestmark = [pytest.mark.unit, pytest.mark.task]
- def lists_equal_ignoring_order(a, b):
- a = a.copy()
- try:
- for item in b:
- a.remove(item)
- except ValueError:
- return False
- return not a
- @patch("backend.lambdas.tasks.generate_queries.write_partitions")
- @patch("backend.lambdas.tasks.generate_queries.batch_sqs_msgs")
- @patch("backend.lambdas.tasks.generate_queries.get_deletion_queue")
- @patch("backend.lambdas.tasks.generate_queries.get_data_mappers")
- @patch("backend.lambdas.tasks.generate_queries.generate_athena_queries")
- def test_it_generates_queries_writes_manifests_populates_queue_and_returns_result(
- gen_athena_queries,
- get_data_mappers,
- get_del_q,
- batch_sqs_msgs_mock,
- write_partitions_mock,
- ):
- queue = [{"MatchId": "hi", "DeletionQueueItemId": "id123"}]
- queries = [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [{"Column": "customer_id"}],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/test/a/manifest.json",
- }
- ]
- data_mapper = {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": ["customer_id"],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- }
- get_del_q.return_value = queue
- gen_athena_queries.return_value = queries
- get_data_mappers.return_value = iter([data_mapper])
- result = handler({"ExecutionName": "test"}, SimpleNamespace())
- gen_athena_queries.assert_called_with(data_mapper, queue, "test")
- write_partitions_mock.assert_called_with([["test", "a"]])
- batch_sqs_msgs_mock.assert_called_with(mock.ANY, queries)
- assert result == {
- "GeneratedQueries": 1,
- "DeletionQueueSize": 1,
- "Manifests": ["s3://S3F2-manifests-bucket/manifests/test/a/manifest.json"],
- }
- @patch("backend.lambdas.tasks.generate_queries.batch_sqs_msgs")
- @patch("backend.lambdas.tasks.generate_queries.get_deletion_queue")
- @patch("backend.lambdas.tasks.generate_queries.get_data_mappers")
- def test_it_raises_for_unknown_query_executor(
- get_data_mappers, get_del_q, batch_sqs_msgs_mock
- ):
- get_del_q.return_value = [{"MatchId": "hi"}]
- get_data_mappers.return_value = iter(
- [
- {
- "DataMapperId": "a",
- "QueryExecutor": "invalid",
- "Columns": ["customer_id"],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- }
- ]
- )
- with pytest.raises(NotImplementedError):
- handler({"ExecutionName": "test"}, SimpleNamespace())
- batch_sqs_msgs_mock.assert_not_called()
- class TestAthenaQueries:
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_single_columns(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-01",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "id-01",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n",
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_int_matches(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id", "Type": "int"}]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": 12345,
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-01",
- },
- {
- "MatchId": 23456,
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-02",
- },
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [
- {
- "Column": "customer_id",
- "Type": "Simple",
- }
- ],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": [12345],
- "DeletionQueueItemId": "id-01",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "12345",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": [23456],
- "DeletionQueueItemId": "id-02",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_decimal_matches(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id", "Type": "decimal"}]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "12.30",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-01",
- },
- {
- "MatchId": "23.400",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-02",
- },
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [
- {
- "Column": "customer_id",
- "Type": "Simple",
- }
- ],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["12.30"],
- "DeletionQueueItemId": "id-01",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "12.30",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["23.400"],
- "DeletionQueueItemId": "id-02",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "23.400",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_int_partitions(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["year"]
- partitions = [["2010"]]
- get_table_mock.return_value = table_stub(
- columns, partition_keys, partition_keys_type="int"
- )
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-01",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [{"Key": "year", "Value": 2010}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "id-01",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n",
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_multiple_columns(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}, {"Name": "alt_customer_id"}]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id-01",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [
- {"Column": "customer_id", "Type": "Simple"},
- {"Column": "alt_customer_id", "Type": "Simple"},
- ],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "id-01",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["alt_customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "id-01",
- "CreatedAt": 1614698440,
- "QueryableColumns": "alt_customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_composite_columns(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [
- {"Name": "first_name"},
- {"Name": "last_name"},
- ]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": [
- {"Column": "first_name", "Value": "John"},
- {"Column": "last_name", "Value": "Doe"},
- ],
- "Type": "Composite",
- "DataMappers": ["a"],
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id1234",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [
- {
- "Columns": ["first_name", "last_name"],
- "Type": "Composite",
- }
- ],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["first_name", "last_name"],
- "MatchId": ["John", "Doe"],
- "DeletionQueueItemId": "id1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name_S3F2COMP_last_name",
- "QueryableMatchId": "John_S3F2COMP_Doe",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_single_composite_column(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "first_name"}]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": [{"Column": "first_name", "Value": "John"}],
- "Type": "Composite",
- "DataMappers": ["a"],
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id1234",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [
- {
- "Columns": ["first_name"],
- "Type": "Composite",
- }
- ],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["first_name"],
- "MatchId": ["John"],
- "DeletionQueueItemId": "id1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name",
- "QueryableMatchId": "John",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_mixed_columns(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [
- {"Name": "customer_id"},
- {"Name": "first_name"},
- {"Name": "last_name"},
- {"Name": "age", "Type": "int"},
- ]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "12345",
- "Type": "Simple",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id001",
- },
- {
- "MatchId": "23456",
- "Type": "Simple",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id002",
- },
- {
- "MatchId": "23456",
- "Type": "Simple",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id003",
- },
- {
- "MatchId": [
- {"Column": "first_name", "Value": "John"},
- {"Column": "last_name", "Value": "Doe"},
- ],
- "Type": "Composite",
- "DataMappers": ["a"],
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id004",
- },
- {
- "MatchId": [
- {"Column": "first_name", "Value": "Jane"},
- {"Column": "last_name", "Value": "Doe"},
- ],
- "Type": "Composite",
- "DataMappers": ["a"],
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id005",
- },
- {
- "MatchId": [
- {"Column": "first_name", "Value": "Jane"},
- {"Column": "last_name", "Value": "Doe"},
- ],
- "Type": "Composite",
- "DataMappers": ["a"],
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id006",
- },
- {
- "MatchId": [
- {"Column": "last_name", "Value": "Smith"},
- {"Column": "age", "Value": "28"},
- ],
- "Type": "Composite",
- "DataMappers": ["a"],
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id007",
- },
- ],
- "job1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [
- {
- "Column": "customer_id",
- "Type": "Simple",
- },
- {
- "Column": "first_name",
- "Type": "Simple",
- },
- {
- "Column": "last_name",
- "Type": "Simple",
- },
- {"Column": "age", "Type": "Simple"},
- {
- "Columns": ["first_name", "last_name"],
- "Type": "Composite",
- },
- {
- "Columns": ["age", "last_name"],
- "Type": "Composite",
- },
- ],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job1234567890/a/manifest.json",
- Body=(
- # id001 simple on all columns
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["12345"],
- "DeletionQueueItemId": "id001",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "12345",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["first_name"],
- "MatchId": ["12345"],
- "DeletionQueueItemId": "id001",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name",
- "QueryableMatchId": "12345",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["last_name"],
- "MatchId": ["12345"],
- "DeletionQueueItemId": "id001",
- "CreatedAt": 1614698440,
- "QueryableColumns": "last_name",
- "QueryableMatchId": "12345",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["age"],
- "MatchId": [12345],
- "DeletionQueueItemId": "id001",
- "CreatedAt": 1614698440,
- "QueryableColumns": "age",
- "QueryableMatchId": "12345",
- }
- )
- + "\n"
- # id002 simple on all columns
- + json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["23456"],
- "DeletionQueueItemId": "id002",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["first_name"],
- "MatchId": ["23456"],
- "DeletionQueueItemId": "id002",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["last_name"],
- "MatchId": ["23456"],
- "DeletionQueueItemId": "id002",
- "CreatedAt": 1614698440,
- "QueryableColumns": "last_name",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["age"],
- "MatchId": [23456],
- "DeletionQueueItemId": "id002",
- "CreatedAt": 1614698440,
- "QueryableColumns": "age",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- # id003 is a id002 clone
- # Values are same as id002 but we cannot deduplicate
- # as we need id003 too for the cleanup phase
- + json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["23456"],
- "DeletionQueueItemId": "id003",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["first_name"],
- "MatchId": ["23456"],
- "DeletionQueueItemId": "id003",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["last_name"],
- "MatchId": ["23456"],
- "DeletionQueueItemId": "id003",
- "CreatedAt": 1614698440,
- "QueryableColumns": "last_name",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- + json.dumps(
- {
- "Columns": ["age"],
- "MatchId": [23456],
- "DeletionQueueItemId": "id003",
- "CreatedAt": 1614698440,
- "QueryableColumns": "age",
- "QueryableMatchId": "23456",
- }
- )
- + "\n"
- # id004 composite multi-column
- + json.dumps(
- {
- "Columns": ["first_name", "last_name"],
- "MatchId": ["John", "Doe"],
- "DeletionQueueItemId": "id004",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name_S3F2COMP_last_name",
- "QueryableMatchId": "John_S3F2COMP_Doe",
- }
- )
- + "\n"
- # id005 composite multi-column
- + json.dumps(
- {
- "Columns": ["first_name", "last_name"],
- "MatchId": ["Jane", "Doe"],
- "DeletionQueueItemId": "id005",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name_S3F2COMP_last_name",
- "QueryableMatchId": "Jane_S3F2COMP_Doe",
- }
- )
- + "\n"
- # id006 is a id005 clone
- + json.dumps(
- {
- "Columns": ["first_name", "last_name"],
- "MatchId": ["Jane", "Doe"],
- "DeletionQueueItemId": "id006",
- "CreatedAt": 1614698440,
- "QueryableColumns": "first_name_S3F2COMP_last_name",
- "QueryableMatchId": "Jane_S3F2COMP_Doe",
- }
- )
- + "\n"
- # id007 composite multi-column with different types
- # note that columns are sorted alphabetically
- + json.dumps(
- {
- "Columns": ["age", "last_name"],
- "MatchId": [28, "Smith"],
- "DeletionQueueItemId": "id007",
- "CreatedAt": 1614698440,
- "QueryableColumns": "age_S3F2COMP_last_name",
- "QueryableMatchId": "28_S3F2COMP_Smith",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_multiple_partition_keys(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["year", "month"]
- partitions = [["2019", "01"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id1234",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [
- {"Key": "year", "Value": "2019"},
- {"Key": "month", "Value": "01"},
- ],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "id1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_multiple_partition_values(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["year", "month"]
- partitions = [["2018", "12"], ["2019", "01"], ["2019", "02"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutor": "athena",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "item1234",
- }
- ],
- "job_1234567890",
- )
- assert lists_equal_ignoring_order(
- resp,
- [
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [
- {"Key": "year", "Value": "2018"},
- {"Key": "month", "Value": "12"},
- ],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [
- {"Key": "year", "Value": "2019"},
- {"Key": "month", "Value": "01"},
- ],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [
- {"Key": "year", "Value": "2019"},
- {"Key": "month", "Value": "02"},
- ],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- ],
- )
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "item1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_propagates_optional_properties(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["year", "month"]
- partitions = [["2018", "12"], ["2019", "01"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- "RoleArn": "arn:aws:iam::accountid:role/rolename",
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": True,
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "item1234",
- }
- ],
- "job_1234567890",
- )
- assert lists_equal_ignoring_order(
- resp,
- [
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [
- {"Key": "year", "Value": "2018"},
- {"Key": "month", "Value": "12"},
- ],
- "RoleArn": "arn:aws:iam::accountid:role/rolename",
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": True,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [
- {"Key": "year", "Value": "2019"},
- {"Key": "month", "Value": "01"},
- ],
- "RoleArn": "arn:aws:iam::accountid:role/rolename",
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": True,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- ],
- )
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "item1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_filters_users_from_non_applicable_tables(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["product_category"]
- partitions = [["Books"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "B",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "B",
- },
- },
- [
- {
- "MatchId": "123",
- "CreatedAt": 1614698440,
- "DataMappers": ["A"],
- "DeletionQueueItemId": "id1",
- },
- {
- "MatchId": "456",
- "CreatedAt": 1614698440,
- "DataMappers": [],
- "DeletionQueueItemId": "id2",
- },
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "B",
- "Database": "test_db",
- "Table": "B",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [{"Key": "product_category", "Value": "Books"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/B/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/B/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["456"],
- "DeletionQueueItemId": "id2",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "456",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_unpartitioned_data(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- get_table_mock.return_value = table_stub(columns, [])
- get_partitions_mock.return_value = []
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "item1234",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "item1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_propagates_role_arn_for_unpartitioned_data(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- get_table_mock.return_value = table_stub(columns, [])
- get_partitions_mock.return_value = []
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- "RoleArn": "arn:aws:iam::accountid:role/rolename",
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "item1234",
- }
- ],
- "job_1234567890",
- )
- assert resp == [
- {
- "DataMapperId": "a",
- "Database": "test_db",
- "Table": "test_table",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [],
- "RoleArn": "arn:aws:iam::accountid:role/rolename",
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- }
- ]
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "item1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_removes_queries_with_no_applicable_matches(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- get_table_mock.return_value = table_stub(columns, [])
- get_partitions_mock.return_value = []
- resp = generate_athena_queries(
- {
- "DataMapperId": "A",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [{"MatchId": "123", "DataMappers": ["B"], "DeletionQueueItemId": "id1234"}],
- "job_1234567890",
- )
- assert resp == []
- assert not put_object_mock.put_object.called
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_removes_queries_with_no_applicable_matches_for_partitioned_data(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["product_category"]
- partitions = [["Books"], ["Beauty"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "A",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- },
- [{"MatchId": "123", "DataMappers": ["C"], "DeletionQueueItemId": "id1234"}],
- "job_1234567890",
- )
- assert resp == []
- assert not put_object_mock.put_object.called
- @patch("backend.lambdas.tasks.generate_queries.glue_client")
- def test_it_returns_table(self, client):
- client.get_table.return_value = {"Table": {"Name": "test"}}
- result = get_table("test_db", "test_table")
- assert {"Name": "test"} == result
- client.get_table.assert_called_with(DatabaseName="test_db", Name="test_table")
- @patch("backend.lambdas.tasks.generate_queries.paginate")
- def test_it_returns_all_partitions(self, paginate):
- paginate.return_value = iter(["blah"])
- result = list(get_partitions("test_db", "test_table"))
- assert ["blah"] == result
- paginate.assert_called_with(
- mock.ANY,
- mock.ANY,
- ["Partitions"],
- **{
- "DatabaseName": "test_db",
- "TableName": "test_table",
- "ExcludeColumnSchema": True,
- }
- )
- def test_it_converts_supported_types(self):
- for scenario in [
- {"value": "m", "type": "char", "expected": "m"},
- {"value": "mystr", "type": "string", "expected": "mystr"},
- {"value": "mystr", "type": "varchar", "expected": "mystr"},
- {"value": "2", "type": "bigint", "expected": 2},
- {"value": "2", "type": "int", "expected": 2},
- {"value": "2", "type": "smallint", "expected": 2},
- {"value": "2", "type": "tinyint", "expected": 2},
- {"value": "2.23", "type": "double", "expected": 2.23},
- {"value": "2.23", "type": "float", "expected": 2.23},
- ]:
- res = cast_to_type(
- scenario["value"],
- "test_col",
- "TableName",
- [
- {
- "Name": "test_col",
- "Type": scenario["type"],
- "CanBeIdentifier": True,
- }
- ],
- )
- assert res == scenario["expected"]
- def test_it_converts_supported_types_when_nested_in_struct(self):
- column_type = "struct<type:int,x:map<string,struct<a:int>>,info:struct<user_id:int,name:string>>"
- tree = list(map(column_mapper, [{"Name": "user", "Type": column_type}]))
- for scenario in [
- {"value": "john_doe", "id": "user.info.name", "expected": "john_doe"},
- {"value": "1234567890", "id": "user.info.user_id", "expected": 1234567890},
- {"value": "1", "id": "user.type", "expected": 1},
- ]:
- res = cast_to_type(scenario["value"], scenario["id"], "TableName", tree)
- assert res == scenario["expected"]
- def test_it_throws_for_unknown_col(self):
- with pytest.raises(ValueError) as e:
- cast_to_type(
- "mystr",
- "doesnt_exist",
- "TableName",
- [{"Name": "test_col", "Type": "string", "CanBeIdentifier": True}],
- )
- assert e.value.args[0] == "Column doesnt_exist not found at table TableName"
- def test_it_throws_for_unsupported_complex_nested_types(self):
- for scenario in [
- "array<x:int>",
- "array<struct<x:int>>",
- "struct<a:array<struct<a:int,x:int>>>",
- "array<struct<a:int,b:struct<x:int>>>",
- "struct<a:map<string,struct<x:int>>>",
- "map<string,struct<x:int>>",
- ]:
- with pytest.raises(ValueError):
- cast_to_type(
- 123,
- "user.x",
- "TableName",
- list(map(column_mapper, [{"Name": "user", "Type": scenario}])),
- )
- def test_it_throws_for_unsupported_col_types(self):
- with pytest.raises(ValueError) as e:
- cast_to_type(
- "2.56",
- "test_col",
- "TableName",
- list(map(column_mapper, [{"Name": "test_col", "Type": "foo"}])),
- )
- assert (
- e.value.args[0]
- == "Column test_col at table TableName is not a supported column type for querying"
- )
- def test_it_throws_for_unconvertable_matches(self):
- with pytest.raises(ValueError):
- cast_to_type(
- "mystr",
- "test_col",
- "TableName",
- list(map(column_mapper, [{"Name": "test_col", "Type": "int"}])),
- )
- def test_it_throws_for_invalid_schema_for_inner_children(self):
- with pytest.raises(ValueError) as e:
- get_inner_children("struct<name:string", "struct<", ">")
- assert e.value.args[0] == "Column schema is not valid"
- def test_it_throws_for_invalid_schema_for_nested_children(self):
- with pytest.raises(ValueError) as e:
- get_nested_children(
- "struct<name:string,age:int,s:struct<n:int>,b:string", "struct"
- )
- assert e.value.args[0] == "Column schema is not valid"
- @patch("backend.lambdas.tasks.generate_queries.s3.Bucket")
- @patch("backend.lambdas.tasks.generate_queries.get_table")
- @patch("backend.lambdas.tasks.generate_queries.get_partitions")
- def test_it_handles_partition_filtering(
- self, get_partitions_mock, get_table_mock, bucket_mock
- ):
- put_object_mock = MagicMock()
- bucket_mock.return_value = put_object_mock
- columns = [{"Name": "customer_id"}]
- partition_keys = ["year", "month"]
- partitions = [["2018", "12"], ["2019", "01"], ["2019", "02"]]
- get_table_mock.return_value = table_stub(columns, partition_keys)
- get_partitions_mock.return_value = [
- partition_stub(p, columns) for p in partitions
- ]
- resp = generate_athena_queries(
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": [col["Name"] for col in columns],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- "PartitionKeys": ["year"],
- },
- },
- [
- {
- "MatchId": "hi",
- "CreatedAt": 1614698440,
- "DeletionQueueItemId": "id1234",
- }
- ],
- "job_1234567890",
- )
- assert lists_equal_ignoring_order(
- resp,
- [
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [{"Key": "year", "Value": "2018"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Format": "parquet",
- "Database": "test_db",
- "Table": "test_table",
- "Columns": [{"Column": "customer_id", "Type": "Simple"}],
- "PartitionKeys": [{"Key": "year", "Value": "2019"}],
- "DeleteOldVersions": True,
- "IgnoreObjectNotFoundExceptions": False,
- "Manifest": "s3://S3F2-manifests-bucket/manifests/job_1234567890/a/manifest.json",
- },
- ],
- )
- put_object_mock.put_object.assert_called_with(
- Key="manifests/job_1234567890/a/manifest.json",
- Body=(
- json.dumps(
- {
- "Columns": ["customer_id"],
- "MatchId": ["hi"],
- "DeletionQueueItemId": "id1234",
- "CreatedAt": 1614698440,
- "QueryableColumns": "customer_id",
- "QueryableMatchId": "hi",
- }
- )
- + "\n"
- ),
- )
- @patch("backend.lambdas.tasks.generate_queries.deserialize_item")
- @patch("backend.lambdas.tasks.generate_queries.paginate")
- def test_it_fetches_deletion_queue_from_ddb(paginate_mock, deserialize_mock):
- item = {"DeletionQueueItems": [{"DataMappers": [], "MatchId": "123"}]}
- deserialize_mock.return_value = item
- paginate_mock.return_value = iter([item])
- resp = get_deletion_queue()
- assert list(resp) == [item]
- @patch("backend.lambdas.tasks.generate_queries.deserialize_item")
- @patch("backend.lambdas.tasks.generate_queries.paginate")
- def test_it_fetches_deserialized_data_mappers(paginate_mock, deserialize_mock):
- dm = {
- "DataMapperId": "a",
- "QueryExecutor": "athena",
- "Columns": ["customer_id"],
- "Format": "parquet",
- "QueryExecutorParameters": {
- "DataCatalogProvider": "glue",
- "Database": "test_db",
- "Table": "test_table",
- },
- }
- deserialize_mock.return_value = dm
- paginate_mock.return_value = iter([dm])
- resp = get_data_mappers()
- assert list(resp) == [dm]
- @patch("backend.lambdas.tasks.generate_queries.glue_client")
- def test_it_writes_glue_partitions(glue_client):
- write_partitions([["job_1234", "dm_0001"], ["job_1234", "dm_0003"]])
- glue_client.batch_create_partition.assert_called_with(
- DatabaseName="s3f2_manifests_database",
- TableName="s3f2_manifests_table",
- PartitionInputList=[
- {
- "Values": ["job_1234", "dm_0001"],
- "StorageDescriptor": {
- "Columns": [
- {"Name": "columns", "Type": "array<string>"},
- {"Name": "matchid", "Type": "array<string>"},
- {"Name": "deletionqueueitemid", "Type": "string"},
- {"Name": "createdat", "Type": "int"},
- {"Name": "queryablecolumns", "Type": "string"},
- {"Name": "queryablematchid", "Type": "string"},
- ],
- "Location": "s3://S3F2-manifests-bucket/manifests/job_1234/dm_0001/",
- "InputFormat": "org.apache.hadoop.mapred.TextInputFormat",
- "OutputFormat": "org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat",
- "Compressed": False,
- "SerdeInfo": {
- "SerializationLibrary": "org.openx.data.jsonserde.JsonSerDe",
- },
- "StoredAsSubDirectories": False,
- },
- },
- {
- "Values": ["job_1234", "dm_0003"],
- "StorageDescriptor": {
- "Columns": [
- {"Name": "columns", "Type": "array<string>"},
- {"Name": "matchid", "Type": "array<string>"},
- {"Name": "deletionqueueitemid", "Type": "string"},
- {"Name": "createdat", "Type": "int"},
- {"Name": "queryablecolumns", "Type": "string"},
- {"Name": "queryablematchid", "Type": "string"},
- ],
- "Location": "s3://S3F2-manifests-bucket/manifests/job_1234/dm_0003/",
- "InputFormat": "org.apache.hadoop.mapred.TextInputFormat",
- "OutputFormat": "org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat",
- "Compressed": False,
- "SerdeInfo": {
- "SerializationLibrary": "org.openx.data.jsonserde.JsonSerDe",
- },
- "StoredAsSubDirectories": False,
- },
- },
- ],
- )
- def partition_stub(values, columns, table_name="test_table"):
- return {
- "Values": values,
- "DatabaseName": "test",
- "TableName": table_name,
- "CreationTime": 1572440736.0,
- "LastAccessTime": 0.0,
- "StorageDescriptor": {
- "Columns": [
- {"Name": col["Name"], "Type": col.get("Type", "string")}
- for col in columns
- ],
- "Location": "s3://bucket/location",
- "InputFormat": "org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat",
- "OutputFormat": "org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat",
- "Compressed": False,
- "NumberOfBuckets": -1,
- "SerdeInfo": {
- "SerializationLibrary": "org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe",
- "Parameters": {"serialization.format": "1"},
- },
- "BucketColumns": [],
- "SortColumns": [],
- "Parameters": {},
- "SkewedInfo": {
- "SkewedColumnNames": [],
- "SkewedColumnValues": [],
- "SkewedColumnValueLocationMaps": {},
- },
- "StoredAsSubDirectories": False,
- },
- }
- def table_stub(
- columns, partition_keys, table_name="test_table", partition_keys_type="string"
- ):
- return {
- "Name": table_name,
- "DatabaseName": "test",
- "Owner": "test",
- "CreateTime": 1572438253.0,
- "UpdateTime": 1572438253.0,
- "LastAccessTime": 0.0,
- "Retention": 0,
- "StorageDescriptor": {
- "Columns": [
- {"Name": col["Name"], "Type": col.get("Type", "string")}
- for col in columns
- ],
- "Location": "s3://bucket/location",
- "InputFormat": "org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat",
- "OutputFormat": "org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat",
- "Compressed": False,
- "NumberOfBuckets": -1,
- "SerdeInfo": {
- "SerializationLibrary": "org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe",
- "Parameters": {"serialization.format": "1"},
- },
- "BucketColumns": [],
- "SortColumns": [],
- "Parameters": {},
- "SkewedInfo": {
- "SkewedColumnNames": [],
- "SkewedColumnValues": [],
- "SkewedColumnValueLocationMaps": {},
- },
- "StoredAsSubDirectories": False,
- },
- "PartitionKeys": [
- {"Name": partition_key, "Type": partition_keys_type}
- for partition_key in partition_keys
- ],
- "TableType": "EXTERNAL_TABLE",
- "Parameters": {"EXTERNAL": "TRUE"},
- }
|